Skip to content

Apache: fix the documentation#2832

Open
squioc wants to merge 1 commit intomainfrom
fix/ApacheDocumentation
Open

Apache: fix the documentation#2832
squioc wants to merge 1 commit intomainfrom
fix/ApacheDocumentation

Conversation

@squioc
Copy link
Contributor

@squioc squioc commented Feb 25, 2026

No description provided.

@squioc squioc requested review from a team and Copilot February 25, 2026 17:24
@squioc squioc added the bug Something isn't working label Feb 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Apache integration documentation to modernize the rsyslog configuration example used to forward Apache access/error logs to Sekoia.io.

Changes:

  • Replaces legacy rsyslog $InputFile* examples with RainerScript input() + ruleset() configuration.
  • Adjusts tags/state handling and adds a stop to prevent further message processing after forwarding.
  • Fixes formatting/indentation in the “Further readings” list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Newest code from squioc has been published to preview environment

🚀 Latest deployment was built on 2026-02-26 08:42:41 (375d4b56bb6e1d444577b23a6882ef07e787e900).

@squioc squioc force-pushed the fix/ApacheDocumentation branch 2 times, most recently from 8862700 to f1bf5fb Compare February 26, 2026 08:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +104 to +105
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placeholder format is inconsistent with the established convention in this codebase. According to the pattern used in other integration documentation files (bind.md:101, haproxy.md:94, spamassassin.md:89-90), placeholders for rsyslog configuration should use angle brackets with mixed case (e.g., <Concentrator_FQDN_or_IP> and <Remote_Port>), not uppercase without angle brackets. Please change CONCENTRATOR_FQDN_OR_IP to <Concentrator_FQDN_or_IP> and REMOTE_PORT to <Remote_Port> to maintain consistency across the documentation.

Suggested change
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
target="<Concentrator_FQDN_or_IP>"
port="<Remote_Port>"

Copilot uses AI. Check for mistakes.
Comment on lines +75 to +111
module(load="imfile" PollingInterval="5")
module(load="omfwd")

input(
type="imfile"
File="/var/log/apache2/error.log"
Tag="apache-error:"
Facility="local5"
Severity="error"
StateFile="stat-apache-error"
PersistStateInterval="200"
Ruleset="apache-logs"
)

input(
type="imfile"
File="/var/log/apache2/access.log"
Tag="apache-access:"
Facility="local5"
Severity="notice"
StateFile="stat-apache-access"
PersistStateInterval="200"
Ruleset="apache-logs"
)

ruleset(name="apache-logs") {
# Forward to remote concentrator
action(
type="omfwd"
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
protocol="tcp"
TCP_Framing="octet-counted"
)
# Prevent further processing of these messages
stop
}
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block content has extra indentation that should be removed. The rsyslog configuration lines (starting from line 75) should not have the leading 8 spaces of indentation. In markdown code blocks, the content should start at the left margin (or with minimal consistent indentation). Compare with similar examples in auditbeat_linux.md:234-254 or varonis_data_security.md:58-76 where the code block content starts at the left margin without extra indentation.

Suggested change
module(load="imfile" PollingInterval="5")
module(load="omfwd")
input(
type="imfile"
File="/var/log/apache2/error.log"
Tag="apache-error:"
Facility="local5"
Severity="error"
StateFile="stat-apache-error"
PersistStateInterval="200"
Ruleset="apache-logs"
)
input(
type="imfile"
File="/var/log/apache2/access.log"
Tag="apache-access:"
Facility="local5"
Severity="notice"
StateFile="stat-apache-access"
PersistStateInterval="200"
Ruleset="apache-logs"
)
ruleset(name="apache-logs") {
# Forward to remote concentrator
action(
type="omfwd"
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
protocol="tcp"
TCP_Framing="octet-counted"
)
# Prevent further processing of these messages
stop
}
module(load="imfile" PollingInterval="5")
module(load="omfwd")
input(
type="imfile"
File="/var/log/apache2/error.log"
Tag="apache-error:"
Facility="local5"
Severity="error"
StateFile="stat-apache-error"
PersistStateInterval="200"
Ruleset="apache-logs"
)
input(
type="imfile"
File="/var/log/apache2/access.log"
Tag="apache-access:"
Facility="local5"
Severity="notice"
StateFile="stat-apache-access"
PersistStateInterval="200"
Ruleset="apache-logs"
)
ruleset(name="apache-logs") {
# Forward to remote concentrator
action(
type="omfwd"
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
protocol="tcp"
TCP_Framing="octet-counted"
)
# Prevent further processing of these messages
stop
}

Copilot uses AI. Check for mistakes.
Comment on lines +100 to +108
ruleset(name="apache-logs") {
# Forward to remote concentrator
action(
type="omfwd"
target="CONCENTRATOR_FQDN_OR_IP"
port="REMOTE_PORT"
protocol="tcp"
TCP_Framing="octet-counted"
)
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example omfwd action forwards Apache logs over plain TCP without any transport encryption, which can expose log contents (URLs, cookies, tokens, or other sensitive data) to interception by an attacker on the network path. An adversary with access to the network between the Apache host and CONCENTRATOR_FQDN_OR_IP could passively capture or tamper with these logs. Consider documenting a configuration that uses TLS (e.g., gtls stream driver and certificate validation) for remote log forwarding, or clearly scoping this example to trusted, isolated networks where plaintext is acceptable.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants